Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-blackbox-exporter] ServiceMonitors should use authorization object defined in the CRD #4492

Open
carl-eberle-pinpoint opened this issue Apr 26, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@carl-eberle-pinpoint
Copy link

Is your feature request related to a problem ?

The blackbox exporter service monitor targets list should support authorization (instead of bearerTokenFile), providing the object doesn't apply to resources when created from the chart.

Describe the solution you'd like.

Service monitors created from this chart should apply the authorization section to the resource.

Describe alternatives you've considered.

bearerTokenFile is deprecated. I do not want to implement something that will be removed at a later time.

Additional context.

No response

@carl-eberle-pinpoint carl-eberle-pinpoint added the enhancement New feature or request label Apr 26, 2024
@jkroepke
Copy link
Member

For new features around the CRDs directly, please open a issue here: https://github.com/prometheus-operator/prometheus-operator

@jkroepke jkroepke closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
@carl-eberle-pinpoint
Copy link
Author

@jkroepke This isn't a CRD issue. It's a missing piece of logic from the service monitor template. It doesn't support something that already exists in the CRD. It needs to be updated to support new functionality in the ServiceMonitor CRD.

@carl-eberle-pinpoint
Copy link
Author

carl-eberle-pinpoint commented Apr 29, 2024

Specifically these lines in the template support only the bearerTokenFile but should also support the authorization object from the CRD.

@jkroepke
Copy link
Member

Did you mean the bearerTokenSecret property?

@carl-eberle-pinpoint
Copy link
Author

Did you mean the bearerTokenSecret property?

I don't see that property in the templates or in the values.yaml file.

@jkroepke
Copy link
Member

Sorry, I was asking, if your are looking for this property?If yes, do you want to create a PR which add this property?

@jkroepke jkroepke reopened this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants