New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prometheus-blackbox-exporter] ServiceMonitors should use authorization object defined in the CRD #4492
Comments
For new features around the CRDs directly, please open a issue here: https://github.com/prometheus-operator/prometheus-operator |
@jkroepke This isn't a CRD issue. It's a missing piece of logic from the service monitor template. It doesn't support something that already exists in the CRD. It needs to be updated to support new functionality in the ServiceMonitor CRD. |
Specifically these lines in the template support only the bearerTokenFile but should also support the authorization object from the CRD. |
Did you mean the |
I don't see that property in the templates or in the values.yaml file. |
Sorry, I was asking, if your are looking for this property?If yes, do you want to create a PR which add this property? |
Is your feature request related to a problem ?
The blackbox exporter service monitor targets list should support authorization (instead of bearerTokenFile), providing the object doesn't apply to resources when created from the chart.
Describe the solution you'd like.
Service monitors created from this chart should apply the authorization section to the resource.
Describe alternatives you've considered.
bearerTokenFile is deprecated. I do not want to implement something that will be removed at a later time.
Additional context.
No response
The text was updated successfully, but these errors were encountered: