add support for monitoring LVM caches #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anarcat
changed the title
anarcat
force-pushed
the
caches
branch
2 times, most recently
from
98135fd
to
d5b9ef3
Compare
anarcat
added a commit
to anarcat/node-exporter-textfile-collector-scripts
that referenced
this pull request
Jun 6, 2023
It seems rather inconvenient to have to specify all those switches by hand. Right now, I need to specify -gpst to get all the stats and, if some new metric get added (e.g. prometheus-community#159 hopefully), I need to remember to update my callers to match. This is annoying. Let's make a -a that's going to do it all for us. Hell, i'd make it the default, personally, if I wasn't worried about breaking people's stuff... This obviously conflicts with other PRs that might add another flag like this, like prometheus-community#159. Please prioritize the latter. Signed-off-by: Antoine Beaupré <anarcat@debian.org>
SuperQ
requested changes
Jun 8, 2023
Signed-off-by: Antoine Beaupré <anarcat@debian.org>
This is basically a copy-paste of the snapshots code, and seems to work on my end. Closes: prometheus-community#158 Signed-off-by: Antoine Beaupré <anarcat@debian.org>
|
@SuperQ ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a copy-paste of the snapshots code, and seems to work on my end.
Closes: #158