Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove md_info scripts as functionality is now included in node_exporter #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove md_info scripts as functionality is now included in node_exporter #109

wants to merge 1 commit into from

Conversation

Kriechi
Copy link

@Kriechi Kriechi commented Dec 27, 2021 •
edited

This PR removes the md_info and md_info_detail collector scripts because their functionality is now included in node_exporter since v1.0.0.

closes #24
closes #25
closes #48
closes #92

For remaining problems, please open a new issue at https://github.com/prometheus/node_exporter

@Kriechi
remove md_info scripts as functionality is now included in node_exporter
7eb2776 
closes prometheus-community#24
closes prometheus-community#25
closes prometheus-community#48
closes prometheus-community#92
For remaining problems, please open a new issue at https://github.com/prometheus/node_exporter

Signed-off-by: Thomas Kriechbaumer <thomas@kriechbaumer.name>
@dswarbrick
Copy link
Member

dswarbrick commented May 19, 2023 •
edited

As much as I would like to deprecate these md_info scripts, I don't think it's accurate to say that their functionality is now in node_exporter.

I assembled a 3-member raid0 on top of some loop devices, and I see the output of md_info.sh as:

node_md_disk_info{disk_device="loop8", md_device="md127"} 1
node_md_disk_info{disk_device="loop9", md_device="md127"} 1
node_md_disk_info{disk_device="loop10", md_device="md127"} 1
node_md_info{md_device="md127", md_name="test", raid_level="0", md_metadata_version="1.2"} 1

Nowhere in the metrics output of node_exporter do I see an equivalent of the node_md_disk_info metric.

Likewise the output of md_info_detail.sh:

node_md_disk_info{disk_device="loop8", md_device="md127"} 1
node_md_disk_info{disk_device="loop9", md_device="md127"} 1
node_md_disk_info{disk_device="loop10", md_device="md127"} 1
node_md_info_ArraySize{md_device="md127", md_name="test", raid_level="0", md_num_raid_disks="3", md_metadata_version="1.2"} 3139584
node_md_info_RaidDevices{md_device="md127", md_name="test", raid_level="0", md_num_raid_disks="3", md_metadata_version="1.2"} 3
node_md_info_TotalDevices{md_device="md127", md_name="test", raid_level="0", md_num_raid_disks="3", md_metadata_version="1.2"} 3
node_md_info_ActiveDevices{md_device="md127", md_name="test", raid_level="0", md_num_raid_disks="3", md_metadata_version="1.2"} 3
node_md_info_WorkingDevices{md_device="md127", md_name="test", raid_level="0", md_num_raid_disks="3", md_metadata_version="1.2"} 3
node_md_info_FailedDevices{md_device="md127", md_name="test", raid_level="0", md_num_raid_disks="3", md_metadata_version="1.2"} 0
node_md_info_SpareDevices{md_device="md127", md_name="test", raid_level="0", md_num_raid_disks="3", md_metadata_version="1.2"} 0
node_md_info_Events{md_device="md127", md_name="test", raid_level="0", md_num_raid_disks="3", md_metadata_version="1.2"} 0
node_md_info{md_device="md127", md_name="test", raid_level="0", md_num_raid_disks="3", md_metadata_version="1.2", devmd127="", Version="1.2", CreationTime="Fri May 19 17:01:03 2023", RaidLevel="raid0", RaidDevices="3", TotalDevices="3", Persistence="Superblock is persistent", State="clean ", ActiveDevices="3", WorkingDevices="3", FailedDevices="0", SpareDevices="0", Layout="-unknown-", ChunkSize="512K", ConsistencyPolicy="none", Name="xps15:test  (local to host xps15)", UUID="68898c67:644f6bfa:18cd114a:b6e2d217"} 1

Despire the poorly-conceived node_md_info metric, there is no equivalent of that currently in node_exporter.

Removing these scripts would be premature at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Kriechi @dswarbrick