Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Auth for Upstream #95

Open
jzelinskie opened this issue Nov 11, 2021 · 1 comment
Open

Basic Auth for Upstream #95

jzelinskie opened this issue Nov 11, 2021 · 1 comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jzelinskie
Copy link
Contributor

I'm not sure if things will just work out of the box if I use the https://user:password@host.com format for the upstream URL. If it does, it should get documented in the README because popular platforms like Grafana Cloud secure their Prometheus with this strategy. If this does not work, it's going to have to be explicitly added upstream, which I don't mind implementing with some direction from the maintainers.
@simonpasquier
Copy link
Contributor

I did a quick check and http://user:password@example.com doesn't work (which looking at httputil.NewSingleHostReverseProxy is logical). I think that your request makes sense.
Maybe users should be able to configure additional headers that would be injected in the incoming request?

@simonpasquier simonpasquier added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jzelinskie @simonpasquier