Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: collect stackdriver metrics globally and include them with the process metrics #175

Open
hsyed-dojo opened this issue Nov 15, 2022 · 0 comments

Comments

@hsyed-dojo
Copy link
Contributor

hsyed-dojo commented Nov 15, 2022

Context in #173.

@SuperQ we are quite close to a single deployment design where we pass filter params to the scrape endpoint.

However, when using this approach the innerHandler registers process scoped metrics (e.g: stackdriver_monitoring_api_calls_total) with the throwaway registry. These are not globally cumulative and they get reset with each scrape.

We would need these to be globally cumulative and (preferably only) available with the process metrics.

What do you think of these changes ?

I have time to work on this this week.

RFC:

  • Should the stackdriver scrape endpoint still include these metrics ? If not this is a breaking change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant