Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: prometheus/client_golang
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.2.0
Choose a base ref
...
head repository: prometheus/client_golang
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.2.1
Choose a head ref
  • 10 commits
  • 8 files changed
  • 2 contributors

Commits on Oct 15, 2019

  1. Use a cleaner initialization of separatorByteSlice 

    The `const separatorByte` wasn't used anymore actually. In `vec.go`,
we were using `model.SeparatorByte`, which is better anyway. So remove
the unused constant and initialize `separatorByteSlice` with
`model.SeparatorByte`, too.

Signed-off-by: beorn7 <beorn@grafana.com>
    @beorn7
    beorn7 committed Oct 15, 2019
    Copy the full SHA
    19af62d View commit details

  2. Merge pull request #659 from prometheus/beorn7/nit 

    Use a cleaner initialization of `separatorByteSlice`
    @beorn7
    beorn7 authored Oct 15, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    39fc195 View commit details

Commits on Oct 16, 2019

  1. Simplify code 

    `gofmt -s` taught me that this is possible.

Signed-off-by: beorn7 <beorn@grafana.com>
    @beorn7
    beorn7 committed Oct 16, 2019
    Copy the full SHA
    679da92 View commit details

  2. Merge pull request #660 from prometheus/beorn7/nit 

    Simplify code
    @beorn7
    beorn7 authored Oct 16, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    b292466 View commit details

Commits on Oct 17, 2019

  1. Add more precise Go version requirements. 

    Signed-off-by: beorn7 <beorn@grafana.com>
    @beorn7
    beorn7 committed Oct 17, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    82cc0ac View commit details

  2. ensure same collectorID calculated on reg and unreg 

    Signed-off-by: Leo Antunes <leo@costela.net>
    @costela
    costela committed Oct 17, 2019
    Copy the full SHA
    4be0ab4 View commit details

  3. Merge pull request #663 from costela/master 

    Fix collectorID calculation for Unregister()
    @beorn7
    beorn7 authored Oct 17, 2019
    Copy the full SHA
    82ce871 View commit details

  4. Merge pull request #664 from prometheus/beorn7/doc 

    Add more precise Go version requirements.
    @beorn7
    beorn7 authored Oct 17, 2019
    Copy the full SHA
    82e1269 View commit details

  5. Cut v1.2.1 

    Signed-off-by: beorn7 <beorn@grafana.com>
    @beorn7
    beorn7 committed Oct 17, 2019
    Copy the full SHA
    8ff8004 View commit details

  6. Merge pull request #665 from prometheus/beorn7/release 

    Cut v1.2.1
    @beorn7
    beorn7 authored Oct 17, 2019
    Copy the full SHA
    5545057 View commit details
Loading