Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions need more exemplar support #1024

Closed
MikeSpreitzer opened this issue Apr 11, 2022 · 2 comments
Closed

Extensions need more exemplar support #1024

MikeSpreitzer opened this issue Apr 11, 2022 · 2 comments

Comments

@MikeSpreitzer
Copy link

I am working on some histogram extensions in kubernetes/kubernetes#109277 , and have run into a couple of blockages regarding examplars.

(1) constHistogram (

type constHistogram struct {
) does not support exemplars.

(2) once it does, I may need to call the private function newExemplar (like histogram::updateExemplar does).

@bwplotka
Copy link
Member

Thanks for this report, but I think it's already implemented. Merged recently with #986

See how to use it here: https://github.com/prometheus/client_golang/blob/main/prometheus/examples_test.go#L601

I will close it for now, but feel free to comment if you think it's should be reopened (something is missing?). Cheers!

@MikeSpreitzer
Copy link
Author

Thanks.
Now I need this to appear in a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants