Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Add documentation for API config options #1036

Closed
kakkoyun opened this issue Apr 25, 2022 · 1 comment · Fixed by #1037
Closed

API: Add documentation for API config options #1036

kakkoyun opened this issue Apr 25, 2022 · 1 comment · Fixed by #1037
Assignees
@josephwoodward
Labels
api help wanted low hanging fruit

Comments

@kakkoyun
Copy link
Member

At first glance I thought this would set the context timeout. I think there should at least be a documentation comment saying what the intended behaviour is.

Originally posted by @bboreham in #1014 (comment)
@josephwoodward
Copy link
Contributor

@kakkoyun Feel free to assign this one to me, I missed the docs on my previous PR.

@josephwoodward josephwoodward mentioned this issue Apr 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephwoodward josephwoodward

Labels
api help wanted low hanging fruit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document WithTimeout option for Query/QueryRange josephwoodward/client_golang
2 participants
@kakkoyun @josephwoodward