Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary check if label is nil in observeWithExemplar instrumentation #1232

Closed
bwplotka opened this issue Mar 17, 2023 · 1 comment

Comments

@bwplotka
Copy link
Member

Tiny task to do: I noticed that

func observeWithExemplar(obs prometheus.Observer, val float64, labels map[string]string) {
is kind of noop as underlying ObserveWithExemplar and AddWithExemplar has already such characteristics. Let's remove unnecessary middle functions.

@bwplotka bwplotka changed the title Remove unnecessary check if label is nil in exemp Remove unnecessary check if label is nil in observeWithExemplar instrumentation Mar 17, 2023
@bwplotka
Copy link
Member Author

Fixed by #1235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant