Add support for custom validations in promlint #1311
Conversation
Signed-off-by: João Vilaça <jvilaca@redhat.com>
Signed-off-by: João Vilaça <jvilaca@redhat.com>
machadovilaca
force-pushed
the
add_support_for_custom_promlint_validations
branch
from
e6697f3
to
83b0350
Compare
prometheus/testutil/lint.go
Outdated
| ) | ||
|
|
||
| // CollectAndLint registers the provided Collector with a newly created pedantic | ||
| // Registry. It then calls GatherAndLint with that Registry and with the | ||
| // provided metricNames. | ||
| func CollectAndLint(c prometheus.Collector, metricNames ...string) ([]promlint.Problem, error) { | ||
| func CollectAndLint(c prometheus.Collector, metricNames ...string) ([]validations.Problem, error) { |
There was a problem hiding this comment.
Can we avoid this?
client_golang is 1.0 and generally we can't break compatibility.
testutil might be experimental (?) - not sure if we ever mentioned it's compatibility level, but if we can-- let's not break the compatibility here. Let's move Problem back to promlint and work from there (perhaps that might require validations to be promlint package).
WDYT?
There was a problem hiding this comment.
I understand your concerns, I will update it and see if I can get a clean solution
There was a problem hiding this comment.
@bwplotka updated
Signed-off-by: João Vilaça <jvilaca@redhat.com>
| for i, t := range dto.MetricType_name { | ||
| if i == int32(dto.MetricType_UNTYPED) { | ||
| continue | ||
| for _, fn := range defaultValidations { |
There was a problem hiding this comment.
Why, why not merging those slices (default and custom) and not repeating the code?
Not a blocker, that's the only nit I would improve, merging anyway.
|
Thanks! I would also recommend adding useful validators to our repo (: |
No description provided.