Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenMetrics unit support (in v1) #684

Open
beorn7 opened this issue Nov 28, 2019 · 7 comments · May be fixed by #1392
Open

OpenMetrics unit support (in v1) #684

beorn7 opened this issue Nov 28, 2019 · 7 comments · May be fixed by #1392
Labels
OpenMetrics OpenMetrics v1
Milestone
OpenMetrics suppo...

Comments

@beorn7
Copy link
Member

beorn7 commented Nov 28, 2019

OpenMetrics offers units as part of the metadata. We can easily add them in the various ...Opts next to Help. They would only be used if OpenMetrics is negotiated as the output format (but they will also implicitly show up in protobuf, cf. prometheus/common#214 ).
@beorn7 beorn7 added this to the OpenMetrics support in v1 milestone Nov 28, 2019
@beorn7 beorn7 changed the title Unit support (in v1) OpenMetrics unit support (in v1) Nov 28, 2019
@bwplotka bwplotka added the OpenMetrics OpenMetrics v1 label Oct 17, 2022
@MadVikingGod MadVikingGod mentioned this issue Nov 18, 2022
Open
@vesari
Copy link

vesari commented Nov 20, 2023

Hello, I'd like to work on this issue

@beorn7
Copy link
Member Author

beorn7 commented Nov 21, 2023

/cc @bwplotka @kakkoyun

@bwplotka
Copy link
Member

Totally, I am supportive. Help wanted @vesari 😊

@ArthurSens
Copy link
Member

Hello, I'd like to work on this issue

Let us know if you need any assistance :)

@vesari
Copy link

vesari commented Nov 21, 2023

Great! I'm on it :)

@vesari vesari linked a pull request Nov 26, 2023 that will close this issue
Open
@vesari
Copy link

vesari commented Dec 2, 2023

@bwplotka @ArthurSens I've opened my first PR in solving this issue: prometheus/client_model#75. Can you please take a look? I'm also opening PRs in prometheus/common and prometheus/client_golang but they both depend on the former.

@ArthurSens
Copy link
Member

Just noticed that Björn was quicker than us with the client_model PR. Feel free to directly ping me in the prometheus/common PR if you need reviewers, I don't receive notifications for that repository 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OpenMetrics OpenMetrics v1
Projects
None yet
Milestone
OpenMetrics support in v1
Development

Successfully merging a pull request may close this issue.

Optionally add OM unit vesari/client_golang
4 participants
@beorn7 @bwplotka @ArthurSens @vesari