Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnRegister doesn't work as expected for Registry Grouping Example #1409

Open
shari0311 opened this issue Dec 18, 2023 · 0 comments
Open

UnRegister doesn't work as expected for Registry Grouping Example #1409

shari0311 opened this issue Dec 18, 2023 · 0 comments

Comments

@shari0311
Copy link

While trying to run the example for grouping registries , unregister always returns false.

defer globalReg.Unregister(workerReg)

The issue seems to be here , the collectorID is not present in the globalRegistry so it always returns false
if _, exists := r.collectorsByID[collectorID]; !exists { r.mtx.RUnlock() return false }

go_version: 1.14 & 1.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant