Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include fqName in the error message when labels are not valid #504

Closed
peterj opened this issue Nov 20, 2018 · 0 comments
Closed

Include fqName in the error message when labels are not valid #504

peterj opened this issue Nov 20, 2018 · 0 comments

Comments

@peterj
Copy link

peterj commented Nov 20, 2018

Currently, if a label is not valid, the following error is displayed:

"error":"\"\" is not a valid label name","level":"error","msg":"error in OpenCensus prometheus exporter","time":"2018-11-20T00:21:07.776067366Z"}

It would be better if fqName as included. For example:

"error":"\"\" is not a valid label name for metric FQNAME","level":"error","msg":"error in OpenCensus prometheus exporter","time":"2018-11-20T00:21:07.776067366Z"}
peterj pushed a commit to peterj/client_golang that referenced this issue Nov 20, 2018
Fixes prometheus#504.

Signed-off-by: Peter Jausovec <peter.jausovec@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant