Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send Graphite metrics with tags #668

Merged
merged 2 commits into from Oct 24, 2019
Merged

Send Graphite metrics with tags #668

merged 2 commits into from Oct 24, 2019

Conversation

kamaev
Copy link
Contributor

@kamaev kamaev commented Oct 22, 2019 •
edited

Hello! I have added some changes to the Bridge struct
and related methods to make it possible to use Graphite tags

@kamaev
Copy link
Contributor Author

kamaev commented Oct 22, 2019

ooops, forgot to remove one thing..

@kamaev
add graphite tags
c333d15 
Signed-off-by: kamaev <timurkamaev@protonmail.com>
@kamaev
fix tests
06342cf 
Signed-off-by: kamaev <timurkamaev@protonmail.com>
@beorn7
Copy link
Member

beorn7 commented Oct 22, 2019

Thanks. Will review ASAP. @stuartnelson3 as the author of the bridge, perhaps you can have a look, too.

stuartnelson3
stuartnelson3 approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me. I'm not familiar with tags, so assuming the tests are correct, I'm fine with this.

beorn7
beorn7 approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too. (As far as I can judge. :o)

Thank you very much.

@beorn7 beorn7 merged commit 333f01c into prometheus:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartnelson3 stuartnelson3 stuartnelson3 approved these changes

@beorn7 beorn7 beorn7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamaev @beorn7 @stuartnelson3