Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does client_golang pull in a second copy of google protobuf? #882

Closed
ggilley opened this issue Jun 20, 2021 · 3 comments
Closed

Why does client_golang pull in a second copy of google protobuf? #882

ggilley opened this issue Jun 20, 2021 · 3 comments

Comments

@ggilley
Copy link

ggilley commented Jun 20, 2021

This package has a lot of dependencies. So I was browsing them (using GitHub insights) looking to see what was used. I see this listed as a dependency:

hkspirt / google_protobuf google.golang.org/protobuf 1.26.0-rc.1

It seems to be a copy of the google protobuf library with a couple of changes? What's it used for?

@beorn7
Copy link
Member

beorn7 commented Jun 21, 2021

I guess this has been pulled in by a requirement of an indirect dependency. It doesn't seem cool to use an RC.

@SuperQ @kakkoyun this happened in #875 . Perhaps you have noticed anything?

@beorn7
Copy link
Member

beorn7 commented Jun 21, 2021

Actually, #881 is already out there fixing this.

@kakkoyun
Copy link
Member

Fixed by #881.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants