Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid le label value on go_gc_pauses_seconds_total_bucket #995

Closed
prymitive opened this issue Mar 4, 2022 · 5 comments
Closed

Invalid le label value on go_gc_pauses_seconds_total_bucket #995

prymitive opened this issue Mar 4, 2022 · 5 comments
Labels

Comments

@prymitive
Copy link
Contributor

Reporting #967 (comment) as a separate issue so it won't get lost

go_gc_pauses_seconds_total_bucket ends up with a negative le bucket and a NaN value for go_gc_pauses_seconds_total_sum

# HELP go_gc_pauses_seconds_total Distribution individual GC-related stop-the-world pause latencies.
# TYPE go_gc_pauses_seconds_total histogram
go_gc_pauses_seconds_total_bucket{le="-5e-324"} 0
go_gc_pauses_seconds_total_bucket{le="9.999999999999999e-10"} 0
go_gc_pauses_seconds_total_bucket{le="9.999999999999999e-09"} 0
go_gc_pauses_seconds_total_bucket{le="1.2799999999999998e-07"} 0
go_gc_pauses_seconds_total_bucket{le="1.2799999999999998e-06"} 0
go_gc_pauses_seconds_total_bucket{le="1.6383999999999998e-05"} 0
go_gc_pauses_seconds_total_bucket{le="0.00016383999999999998"} 3307
go_gc_pauses_seconds_total_bucket{le="0.0020971519999999997"} 6712
go_gc_pauses_seconds_total_bucket{le="0.020971519999999997"} 6809
go_gc_pauses_seconds_total_bucket{le="0.26843545599999996"} 6812
go_gc_pauses_seconds_total_bucket{le="+Inf"} 6812
go_gc_pauses_seconds_total_sum NaN
go_gc_pauses_seconds_total_count 6812
@kakkoyun kakkoyun added the bug label Mar 17, 2022
@kakkoyun
Copy link
Member

I guess there's a legitimate answer to that in the same thread by @mknyszek #967 (comment)

That being said, we could consider an absorbing the negative values here.

@fly3366
Copy link

fly3366 commented Apr 30, 2022

Calculate quantile need bucket include Inf, but main branch has exclude Inf. So quantile return NaN. if someone need a patch, I will pr.

@kakkoyun
Copy link
Member

kakkoyun commented May 2, 2022

@fly3366 Feel free to contribute. The contributions are always welcome 🤗 Please note we have reverted new enabling new collector by default and this is a bug in that. See #1033. There are several other issues we need to take care of for the new collector, so again help is very much appriciated.

@kakkoyun
Copy link
Member

Fixed with #1049

@sidh
Copy link

sidh commented May 31, 2022

Confirming bug is fixed in 1.12.2.

ti-mo added a commit to ti-mo/cilium that referenced this issue Jun 3, 2022
…e gone"

This reverts commit 9febe6b.

---

prometheus/client_golang#995 has been solved.

Signed-off-by: Timo Beckers <timo@isovalent.com>
aanm pushed a commit to cilium/cilium that referenced this issue Jun 3, 2022
…e gone"

This reverts commit 9febe6b.

---

prometheus/client_golang#995 has been solved.

Signed-off-by: Timo Beckers <timo@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants