Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated NewBuildInfoCollector API #1000

Merged
merged 2 commits into from Mar 17, 2022
Merged

Fix deprecated NewBuildInfoCollector API #1000

merged 2 commits into from Mar 17, 2022

Conversation

alissa-tung
Copy link
Contributor

@alissa-tung alissa-tung commented Mar 15, 2022 •
edited

  1. Update examples/random/main.go: prometheus.NewBuildInfoCollector is deprecated. Use collectors.NewBuildInfoCollector instead.

bwplotka
bwplotka requested changes Mar 16, 2022
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

But can we remove main binary from this PR? I think it was added by accident.

@alissa-tung
Copy link
Contributor Author

Nice!

But can we remove main binary from this PR? I think it was added by accident.

sorry i gonna give a fix

kakkoyun
kakkoyun approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakkoyun
Copy link
Member

@bwplotka Feel free to merge :)

@kakkoyun
Copy link
Member

@alissa-tung Would you mind maybe adding comment changes in this PR as well here? #918

@kakkoyun kakkoyun mentioned this pull request Mar 16, 2022
Closed
@alissa-tung
Copy link
Contributor Author

@alissa-tung Would you mind maybe adding comment changes in this PR as well here? #918

done

@kakkoyun
Copy link
Member

@alissa-tung By any chance you forgot to push? I don't see the changes

@alissa-tung
Fix deprecated NewBuildInfoCollector API
b05177a 
Update `examples/random/main.go`:
  `prometheus.NewBuildInfoCollector` is deprecated. Use `collectors.NewBuildInfoCollector` instead.

Signed-off-by: alissa-tung <alissa-tung@outlook.com>
@alissa-tung
Copy link
Contributor Author

@alissa-tung By any chance you forgot to push? I don't see the changes

yes, sorry :(

@kakkoyun
Copy link
Member

@alissa-tung By any chance you forgot to push? I don't see the changes

yes, sorry :(

Still the same :/

@alissa-tung
Copy link
Contributor Author

@alissa-tung By any chance you forgot to push? I don't see the changes

yes, sorry :(

Still the same :/

https://github.com/prometheus/client_golang/pull/1000/commits

i though there are some commit message comment here 🤔 im not native English speaker, im afraid that there is something i misunderstood

@alissa-tung @zestloveheart
Update Dockerfile example
ffd6362 
Signed-off-by: alissa-tung <alissa-tung@outlook.com>

Co-authored-by: Cruise_Hua <zlh429375251@qq.com>
@alissa-tung
Copy link
Contributor Author

is ffd6362 work as expected?

@kakkoyun
Copy link
Member

is ffd6362 work as expected?

Yes, thanks 🙏

kakkoyun
kakkoyun approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakkoyun kakkoyun merged commit fe8d1e1 into prometheus:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

@bwplotka bwplotka Awaiting requested review from bwplotka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alissa-tung @kakkoyun @bwplotka