Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: Update dependencies #1018

Merged
merged 1 commit into from Mar 29, 2022
Merged

go.mod: Update dependencies #1018

merged 1 commit into from Mar 29, 2022

Conversation

mrueg
Copy link
Contributor

@mrueg mrueg commented Mar 29, 2022

In particular, update to prometheus/common v0.33.0

fwiw it looks like prometheus/common and prometheus/client_golang depend on each other. Not sure how to break the dependency here.

github.com/prometheus/client_golang github.com/prometheus/common@v0.33.0
github.com/prometheus/common@v0.33.0 github.com/prometheus/client_golang@v1.12.1
github.com/prometheus/client_golang@v1.12.1 github.com/prometheus/common@v0.32.1
github.com/prometheus/common@v0.32.1 github.com/prometheus/client_golang@v1.11.0
github.com/prometheus/client_golang@v1.11.0 github.com/prometheus/common@v0.26.0
github.com/prometheus/common@v0.26.0 github.com/prometheus/client_golang@v1.7.1
github.com/prometheus/client_golang@v1.7.1 github.com/prometheus/common@v0.10.0
github.com/prometheus/common@v0.10.0 github.com/prometheus/client_golang@v1.0.0
github.com/prometheus/client_golang@v1.0.0 github.com/prometheus/common@v0.4.1
github.com/prometheus/common@v0.4.1 github.com/prometheus/client_golang@v0.9.1

@mrueg
go.mod: Update dependencies
b0bff7c 
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
bwplotka
bwplotka approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Any problems caused by module circular import here?

@bwplotka bwplotka merged commit 29e8191 into prometheus:main Mar 29, 2022
@bwplotka
Copy link
Member

well there is #1012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrueg @bwplotka