Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cespare/xxhash dependency #913

Merged
merged 1 commit into from Sep 29, 2021
Merged

Conversation

dtrudg
Copy link
Contributor

@dtrudg dtrudg commented Sep 21, 2021

Brings in a fix for asm errors when dynamic linking with Go 1.17.

Fixes #912

Signed-off-by: David Trudgian david.trudgian@sylabs.io

Brings in a fix for asm errors when dynamic linking with Go 1.17.

Fixes prometheus#912

Signed-off-by: David Trudgian <david.trudgian@sylabs.io>
@dtrudg dtrudg marked this pull request as ready for review September 21, 2021 16:04
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤗

@bwplotka bwplotka merged commit 679eb0d into prometheus:master Sep 29, 2021
@pacoxu
Copy link

pacoxu commented Nov 1, 2021

There is no new release after this PR was merged for about 2 months.

Can some owners help to release a new version?
/cc @kakkoyun @beorn7

kubernetes/kubernetes#105142 is pending on new release.

wI2L pushed a commit to ovh/utask that referenced this pull request Feb 28, 2023
Update indirect dependency cespare/xxhash to v2.1.2.
See prometheus/client_golang#913
wI2L pushed a commit to ovh/utask that referenced this pull request Feb 28, 2023
Update indirect dependency cespare/xxhash to v2.1.2.
See prometheus/client_golang#913

Signed-off-by: William Poussier <william.poussier@ovhcloud.com>
wI2L added a commit to ovh/utask that referenced this pull request Feb 28, 2023
Update indirect dependency cespare/xxhash to v2.1.2.
See prometheus/client_golang#913

Signed-off-by: William Poussier <william.poussier@ovhcloud.com>
Co-authored-by: William Poussier <william.poussier@ovhcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for github.com/cespare/xxhash/v2 to avoid asm errors with go 1.17
3 participants