From 6d97edbd9c748c9913ce0d2231451c3e5b67735f Mon Sep 17 00:00:00 2001
From: SuperQ <superq@gmail.com>
Date: Mon, 15 Apr 2024 11:46:58 +0200
Subject: [PATCH] Fix up config test

Make code more readable by replacing overly generic `trueValue` with the
actual meaning `marshalSecret`.

Fixes: https://github.com/prometheus/common/pull/487

Signed-off-by: SuperQ <superq@gmail.com>
---
 config/config_test.go | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/config/config_test.go b/config/config_test.go
index 51d23407..af499d1e 100644
--- a/config/config_test.go
+++ b/config/config_test.go
@@ -28,11 +28,11 @@ func TestJSONMarshalSecret(t *testing.T) {
 		S Secret
 	}
 	for _, tc := range []struct {
-		desc      string
-		data      tmp
-		expected  string
-		trueValue bool
-		testYAML  bool
+		desc          string
+		data          tmp
+		expected      string
+		marshalSecret bool
+		testYAML      bool
 	}{
 		{
 			desc: "inhabited",
@@ -42,18 +42,18 @@ func TestJSONMarshalSecret(t *testing.T) {
 			expected: "{\"S\":\"\\u003csecret\\u003e\"}",
 		},
 		{
-			desc:      "true value in JSON",
-			data:      tmp{"test"},
-			expected:  `{"S":"test"}`,
-			trueValue: true,
+			desc:          "true value in JSON",
+			data:          tmp{"test"},
+			expected:      `{"S":"test"}`,
+			marshalSecret: true,
 		},
 		{
 			desc: "true value in YAML",
 			data: tmp{"test"},
 			expected: `s: test
 `,
-			trueValue: true,
-			testYAML:  true,
+			marshalSecret: true,
+			testYAML:      true,
 		},
 		{
 			desc:     "empty",
@@ -62,7 +62,7 @@ func TestJSONMarshalSecret(t *testing.T) {
 		},
 	} {
 		t.Run(tc.desc, func(t *testing.T) {
-			MarshalSecretValue = tc.trueValue
+			MarshalSecretValue = tc.marshalSecret
 
 			var marshalFN func(any) ([]byte, error)
 			if tc.testYAML {