Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GRPC to latest release #7836

Closed
roidelapluie opened this issue Aug 23, 2020 · 3 comments
Closed

Update GRPC to latest release #7836

roidelapluie opened this issue Aug 23, 2020 · 3 comments

Comments

@roidelapluie
Copy link
Member

roidelapluie commented Aug 23, 2020

@beorn7 @codesome

In the latest release, we had to rollback the GRPC release.

Can we now update GRPC for v1.31.0? (see #7621)

It is annoying not to update it because in the last month some dependencies depend on newer releases.

@roidelapluie roidelapluie changed the title Update GRPC Update GRPC to latest release Aug 23, 2020
@roidelapluie
Copy link
Member Author

roidelapluie commented Aug 23, 2020

etcd-io/etcd#12124 is still not fixed :(

@codesome
Copy link
Member

And looks like it is going to take some time etcd-io/etcd#12124 (comment), but I see some push there. Upgrading gRPC in Prometheus would entirely block Cortex from vendoring Prometheus :/

If the dependencies in Prometheus which depend on latest gRPC are not critical to be upgraded or not blocking any work, we could consider waiting for it to be upgraded in etcd.

@zmt
Copy link

zmt commented Feb 18, 2022

This comment in go.mod led me to this issue, but this issue can almost certainly be closed and that comment removed since I see many newer versions of grpc in go.sum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants