Remove unmaintained example #842
Conversation
SuperQ
force-pushed
the
superq/cleanup_broken_config
branch
from
27f868a
to
4894bbd
Compare
We don't generally maintain example service configs in our repos. This is more appropriately handled by prometheus-community/ansible. Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/cleanup_broken_config
branch
from
4894bbd
to
97a2a92
Compare
There was a problem hiding this comment.
Weird; my reply email went in, I got an update from GH with my response, then a bounce, and now my reply is gone.
I would prefer to keep (and by extension maintain) this for all exporters. More docs & handholding is always good. People won't know where the Ansible lives or how to copy from it in the common case, I fear.
|
I really don't want to maintain these examples, we don't have any consistency for this stuff on any of our repos. Same reason why I don't like maintaining random init scripts, runit configs, supervisord configs, etc. |
|
Semi-random idea: What if we put it into exporter-toolkit? |
|
I agree that systemd service files, init scripts etc should really be provided by the distros which package the exporters, since they usually involve distro-specific paths, users / groups, etc. |
|
Closing this for now. |
We don't generally maintain example service configs in our repos. This is more appropriately handled by prometheus-community/ansible.
Fixes: #832
Signed-off-by: SuperQ superq@gmail.com