Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble with 1.7.2 and i18n behaviour #1085

Open
shodanto opened this issue Jun 12, 2020 · 0 comments
Open

Trouble with 1.7.2 and i18n behaviour #1085

shodanto opened this issue Jun 12, 2020 · 0 comments

Comments

@shodanto
Copy link

Since 1.7.2 i am having trouble with the i18n behaviour. It changed and doesn't deliver the proper language object.
Code:

CategoryQuery::Create()->joinWithI18n(getLocale())->filterByIsMenu(true)->filterByParentId($category->getCategoryId())->useCategoryI18nQuery()->filterByIsactive(true)->enduse()->orderBySort()->find()

Executed query 1.7.1:
SELECT .. FROM categoryLEFT JOINcategory_i18nON (category.categoryId=category_i18n.categoryId AND category_i18n.locale = 'de_DE') WHERE category.isMenu=1 AND category.parentId_second=5 AND category_i18n.isActive=1 ORDER BY category.sort_second ASC;

Executed query 1.7.2:
SELECT ... FROM categoryLEFT JOINcategory_i18nON (category.categoryId=category_i18n.categoryId) WHERE category.isMenu=1 AND category.parentId=10 AND category_i18n.isActive=1 ORDER BY category.sort ASC;

The Problem lies in class Join.php line 580;

 return $join !== null
            && $join instanceof Join
            && $this->getJoinType() == $join->getJoinType()
            && $this->getConditions() == $join->getConditions()
            **&& $this->getClause($parametersOfThisClauses) == $join-> >getClause($parametersOfJoinClauses);** //this line has been added
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant