Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown rendering doesn't seem ideal #20

Open
nesium opened this issue Feb 8, 2024 · 9 comments
Open

Markdown rendering doesn't seem ideal #20

nesium opened this issue Feb 8, 2024 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@nesium
Copy link

nesium commented Feb 8, 2024

Writing F*ing nice in a message gets rendered as if it were F*ing nice*

@valeriansaliou
Copy link
Member

Sounds like it could be a snarkdown issue.

@valeriansaliou valeriansaliou self-assigned this Feb 8, 2024
@valeriansaliou valeriansaliou added the bug Something isn't working label Feb 8, 2024
@nesium
Copy link
Author

nesium commented Feb 8, 2024

Jup. It also seems like code and quotes are not parsed/rendered properly. Although I don't know if we even have styles for that yet (quotes that is, code blocks I have seen).

@valeriansaliou
Copy link
Member

No, we have no style for Markdown just yet. I'll open a separate issue for that.

@nesium
Copy link
Author

nesium commented Feb 14, 2024

Another case:

Text:

Feb 13 20:43:50 modulemanager   error   Error initializing module 'storage_sql' on 'proxy.ssk.pm': /usr/share/lua/5.1/pr
osody/util/startup.lua:203: module 'DBI' not found:No LuaRocks module found for DBI
        no field package.preload['DBI']
        no file './prosody/DBI.lua'
        no file './DBI.lua'
        no file '/usr/local/share/lua/5.1/prosody/DBI.lua'
        no file '/usr/local/share/lua/5.1/DBI.lua'

Result snarkdown:
Screenshot 2024-02-14 at 13 43 55

Result Github:
Screenshot 2024-02-14 at 13 47 38

I think we should use a "proper" Markdown parser, i.e. something that is tested against CommonMark.

@nesium
Copy link
Author

nesium commented Feb 14, 2024

Last example:

Text:

http://upload.nsm.chat:5280/file_share/bYBeUDWO9fctt0OrbX1eTStw/brooke-lark-kVCRP3uiLiE-unsplash.jpg

Result snarkdown:
Screenshot 2024-02-14 at 14 20 19

@valeriansaliou
Copy link
Member

I may want to change Markdown library there, looks like it's causing too much trouble!

@nesium
Copy link
Author

nesium commented Apr 17, 2024

I'm going to reopen this. See examples…

Screenshot 2024-04-17 at 10 39 52 Screenshot 2024-04-17 at 10 40 16

@nesium nesium reopened this Apr 17, 2024
@nesium
Copy link
Author

nesium commented Jun 3, 2024

New issue:

The message…

​```
1
2
3
​```

Renders as

2
3

@nesium
Copy link
Author

nesium commented Jun 4, 2024

Lists only render at the beginning of the message or after a newline:

Works:

​```
- A
- B
​```

Works:

​```
Some text

- A
- B
​```

Does not work:

​```
Some text
- A
- B
​```

Github renders it as expected:

Some text

  • A
  • B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants