Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room discovery #4

Open
nesium opened this issue Nov 7, 2023 · 0 comments
Open

Room discovery #4

nesium opened this issue Nov 7, 2023 · 0 comments

Comments

@nesium
Copy link

nesium commented Nov 7, 2023

I believe that a MUC service only ever returns public rooms: https://xmpp.org/extensions/xep-0045.html#disco-rooms

From a user perspective however when browsing channels I would expect to see private channels, that I've been invited to, as well.

We could of course list all public channels as well as private channels from the user's bookmarks. That begs the question if the server should automatically create a bookmark for a user when that user is invited to a channel.

nesium added a commit to prose-im/prose-core-client that referenced this issue Nov 10, 2023
closes #34, refs prose-im/prose-pod-system#4

- Bookmarks are now saved in a custom PubSub (PEP) node
- Bookmarks for Private Channels are never deleted, only marked as “not in sidebar” so that we don’t loose track of them (needs a new method to browse all available channels)
- Groups - even when not visible in the sidebar - are always joined, so that they behave like direct messages
- When a mesage from a group is received, the group will automatically be added back to the sidebar

Breaking change: JSDelegate callback was renamed from `roomsChanged` to `sidebarChanged`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant