Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is removing a property from a datacontract Class (not currently used by The client) a breaking Change? #310

Open
sabbadino opened this issue Oct 4, 2023 · 2 comments
Open

Is removing a property from a datacontract Class (not currently used by The client) a breaking Change? #310

sabbadino opened this issue Oct 4, 2023 · 2 comments

Comments

@sabbadino
Copy link

Is removing a property from a datacontract Class (not currently used by The client) a breaking Change for the client?
@sabbadino
Copy link
Author

I did a repro and it looks like not being a breaking Change (of course i left the Order of the other properties un touched

@mgravell
Copy link
Member

mgravell commented Oct 4, 2023

No, it isn't. You may want to make use of [ProtoReserved] (IIRC, not at PC) to ensure you don't reuse it in unfortunate ways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgravell @sabbadino