From 119d90aa1ce14d7bff20bb1dcc1ddc4544a80c23 Mon Sep 17 00:00:00 2001 From: Alexander Fenster Date: Thu, 22 Sep 2022 11:28:36 -0700 Subject: [PATCH] fix(types): nested object can be a oneof (#1812) --- index.d.ts | 2 +- src/namespace.js | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/index.d.ts b/index.d.ts index f112654b0..750ad2f73 100644 --- a/index.d.ts +++ b/index.d.ts @@ -863,7 +863,7 @@ export interface INamespace { type AnyExtensionField = (IExtensionField|IExtensionMapField); /** Any nested object descriptor. */ -type AnyNestedObject = (IEnum|IType|IService|AnyExtensionField|INamespace); +type AnyNestedObject = (IEnum|IType|IService|AnyExtensionField|INamespace|IOneOf); /** Base class of all reflection objects. */ export abstract class ReflectionObject { diff --git a/src/namespace.js b/src/namespace.js index 0f0ba6306..731afc75f 100644 --- a/src/namespace.js +++ b/src/namespace.js @@ -143,9 +143,8 @@ Object.defineProperty(Namespace.prototype, "nestedArray", { /** * Any nested object descriptor. * @typedef AnyNestedObject - * @type {IEnum|IType|IService|AnyExtensionField|INamespace} + * @type {IEnum|IType|IService|AnyExtensionField|INamespace|IOneOf} */ -// ^ BEWARE: VSCode hangs forever when using more than 5 types (that's why AnyExtensionField exists in the first place) /** * Converts this namespace to a namespace descriptor.