Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing types from 'Long' in generated .d.ts file #1796

Closed
ffflorian opened this issue Aug 29, 2022 · 2 comments · Fixed by #1802
Closed

Missing types from 'Long' in generated .d.ts file #1796

ffflorian opened this issue Aug 29, 2022 · 2 comments · Fixed by #1802

Comments

@ffflorian
Copy link
Contributor

protobuf.js version: 7.1.0

Expected behaviour:

  • protobuf file converted with pbts adds an import from Long in the generated .d.ts file, e.g.
import Long = require('long');

Actual behaviour:

  • no import was found

Used command:

pbts --out proto/export.d.ts --no-comments proto/export.js
@alexander-fenster alexander-fenster mentioned this issue Sep 9, 2022
Merged
@alexander-fenster
Copy link
Contributor

Yeah, it seems the import got lost in a sequence of refactors. Adding it back in #1802.

@ffflorian
Copy link
Contributor Author

Thank you!

@Goldabj Goldabj mentioned this issue Mar 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add import long to the generated .d.ts protobufjs/protobuf.js
2 participants
@alexander-fenster @ffflorian