Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom npm packages in imported protos #165

Open
jasonbrown-alis opened this issue Mar 8, 2023 · 1 comment
Open

Allow for custom npm packages in imported protos #165

jasonbrown-alis opened this issue Mar 8, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers packaging & distribution triaged Issue has been triaged

Comments

@jasonbrown-alis
Copy link

jasonbrown-alis commented Mar 8, 2023

Here is a link to the line where it speaks to our issue.

// Well-known types (.proto files in the google/protobuf directory) are
// assumed to come from the 'google-protobuf' npm package. We may want to
// generalize this exception later by letting others put generated code in
// their own npm packages.

We currently make use of a variety of google protos other than those in the google-protobuf npm package. To make use of these, we have to explicitly include them in the npm package that we publish containing our generated protobufs. It would be ideal if we could publish the generated google protobufs we use in a separate npm package and use options in the .proto files to specify the name of the package to which these are published, and for this package to be used in the generated code whenever one of these protobufs is implemeneted. Similar to how this is for the "google-protobuf" imports

@dibenede
Copy link
Contributor

From triage: We should consider doing this to make things easier for folks.

@dibenede dibenede added enhancement New feature or request good first issue Good for newcomers packaging & distribution triaged Issue has been triaged labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers packaging & distribution triaged Issue has been triaged
Projects
None yet
Development

No branches or pull requests

2 participants