Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: protocolbuffers/protobuf
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.17.0
Choose a base ref
...
head repository: protocolbuffers/protobuf
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.17.1
Choose a head ref
  • 4 commits
  • 73 files changed
  • 2 contributors

Commits on May 17, 2021

  1. Fixed syntax errors in bswap_64 (#8613)

    It looks like some syntax errors were introduced by mistake because some
    left parentheses were changed to curly braces without the right parens
    being changed accordingly. This fixes #8611.
    acozzette authored May 17, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    65abb64 View commit details

Commits on May 19, 2021

  1. Php & Ruby Cherry Picks for 3.17.1 (#8632)

    * Some more updates to PHP testing infrastructure (#8576)
    
    * WIP.
    
    * Added build config for all of the tests.
    
    * Use ../src/protoc if it is available, for cases where Bazel isn't available.
    
    * Added test_php.sh.
    
    * Fix for the broken macOS tests.
    
    * Move all jobs to use php80 instead of lots of separate jobs.
    
    * Only pass -t flag if we are running in a terminal.
    
    * Updated php_all job to use new Docker stuff.
    
    * Fixed PHP memory leaks and arginfo errors (#8614)
    
    * Fixed a bunch of incorrect arginfo and a few incorrect error messages.
    
    * Passes mem check test with no leaks!
    
    * WIP.
    
    * Fix build warning that was causing Bazel build to fail.
    
    * Added compatibility code for PHP <8.0.
    
    * Added test_valgrind target and made tests Valgrind-clean.
    
    * Updated Valgrind test to fail if memory leaks are detected.
    
    * Removed intermediate shell script so commands are easier to cut, paste, and modify.
    
    * Passing all Valgrind tests!
    
    * Hoist addref into ObjCache_Get().
    
    * Removed special case of map descriptors by keying object map on upb_msgdef.
    
    * Removed all remaining RETURN_ZVAL() macros.
    
    * Removed all explicit reference add/del operations.
    
    * Added REFCOUNTING.md to Makefile.am.
    
    * Updated upb version and fixed PHP to not get unset message field. (#8621)
    
    * Updated upb version and fixed PHP to not get unset message field.
    
    * Updated changelog.
    
    * Fixed preproc test to handle old versions of Clang withot __has_attribute().
    
    * A second try at fixing __has_attribute().
    
    * Copy __has_attribute() fix to cc file also.
    
    * Updated failure list for PHP for fixed test.
    
    * Updated version of upb for Ruby (#8624)
    
    * Updated upb.
    
    * Preserve legacy behavior for unset messages.
    
    * Updated failure list.
    
    * Updated CHANGES.txt.
    
    * Added erroneously-deleted test file.
    
    * Fixed condition on compatibility code.
    
    * Re-introduced deleted file again, and fixed Rakefile to not delete it.
    
    * Fix generation of test protos.
    haberman authored May 19, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    0b87475 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    52784ce View commit details

Commits on May 22, 2021

  1. Fixed memory bug: properly root repeated/map field when assigning. (#…

    …8639)
    
    * Fixed memory bug: properly root repeated/map field when assigning.
    
    Previously the protobuf extension would not properly root
    memory from a repeated field or map when assigning to a
    message field (see the attached test case).  This could cause
    crashes if the repeated field is subsequently accessed.
    
    * Add accidentally-deleted Ruby test.
    haberman authored May 22, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    367e469 View commit details
Loading