Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: protocolbuffers/protobuf
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.19.3
Choose a base ref
...
head repository: protocolbuffers/protobuf
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.19.4
Choose a head ref
  • 9 commits
  • 45 files changed
  • 3 contributors

Commits on Jan 25, 2022

  1. Make libprotobuf symbols local on OSX (#8346) (#9435)

    @gnossen gave a great overview in grpc/grpc#24992 of the overall problem.
    
    If a python process using both protobuf _and_ another native library linking in libprotobuf
    frequently can cause crashes.  This seems to frequently affect tensorflow as well:
    
    tensorflow/tensorflow#8394,
    tensorflow/tensorflow#9525 (comment)
    tensorflow/tensorflow#24976,
    tensorflow/tensorflow#35573,
    https://github.com/tensorflow/tensorflow/blob/v2.0.0/tensorflow/contrib/makefile/rename_protobuf.sh,
    tensorflow/tensorflow#16104
    
    Testing locally this fixes both crashes when linking in multiple versions of protobuf
    and fixes `DescriptorPool` clashes as well (e.g. Python and Native code import different versions of the same message).
    
    Co-authored-by: Roy Williams <roy.williams.iii@gmail.com>
    acozzette and rowillia authored Jan 25, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    a035bd0 View commit details

Commits on Jan 28, 2022

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    779b972 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    67995fb View commit details
  3. Added CHANGES.txt entry.

    haberman committed Jan 28, 2022
    Copy the full SHA
    35a21c1 View commit details
  4. Copy the full SHA
    aceff71 View commit details
  5. Merge pull request #9450 from haberman/php-dataloss-bugfix

    Fixed data loss bug in PHP C extension
    haberman authored Jan 28, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    eb301e1 View commit details
  6. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    98b8e05 View commit details
  7. Merge pull request #9451 from haberman/ruby-dataloss-bugfix

    Fixed data loss bug in Ruby extension
    haberman authored Jan 28, 2022
    Copy the full SHA
    afeb6d8 View commit details
  8. Update protobuf version for 3.19.4 (#9449)

    I also updated the PHP release notes in
    php/ext/google/protobuf/package.xml.
    acozzette authored Jan 28, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    22d0e26 View commit details
Loading