New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby 3.2 support #11407
Comments
This limitation is only on the precompiled binaries. Different platform gems have different ruby requirements:
The version that isn't compiled has no maximum version number so should be able to build. That works locally for me, but I'm also deploying with a buildpack and haven't succeeded in telling it to compile rather than fetch the precompiled version. |
I have the same problem, I can install google-protobuf 3.21.12 just fine, but specifying it as an explicit dependency in my Gemfile doesn't solve the problem because it looks for the precompiled version anyway. Is there a way to override this behavior? |
Ah I just solved it. I accidentally ran |
@tinco Have you managed to deploy it ? I have the same error when I try to deploy to github-pages. Even if I specify the gem google-protobuf 3.21.12 in the Gemfile nothing seems to change. (I am using Bundler 2.4.1) |
Yeah, I got some more errors I didn't understand so I just removed the Gemfile.lock and ran bundle update. That fixed all issues, but it requires you run a diff with the old Gemfile.lock to see if there's any major version upgrades with incompatibilities. I reserved the whole day to fix those. |
Eh also make sure you actually uninstall the old bundler with |
Even after updating the bundler and regenerating the Gemfile.lock I still have an issue as the google-protobuf 3.21.12-x86_64-linux is used by default. But thank you for the help ! |
I was poking at this on Heroku yesterday too and gave up. |
Looks like this may be related to an issue in Bundler 2.4.2 which is keeping it from falling back to the 'ruby' platform when precompiled binaries aren't appropriate (see rubygems/rubygems#6237) This happens with every major release and will also require changes to the build process to (similar to these changes for 3.1.0) so future releases will include 3.2.0 binaries. It usually takes 2-3 months before google-protobuf gets updated for the new version of Ruby. |
Looks like installing protobuf is working now with rubygems 3.4.3 and bundler 2.4.3 (both released today). Make sure to update bundler in the lock file ( |
The error remains after deploying on GH pages, google-protobuf-3.21.12-x86_64-linux is fetched instead of google-protobuf-3.21.12. |
I'm not sure what is the key, but could deploy to Heroku with the following Gemfile.lock 🎉
|
@JunichiIto But as far as I can tell, that doesn't fix the issue of prebuilt binaries not supporting 3.2. That just removes the prebuilt binary from your Gemfile.lock Can you confirm by deployment log, that it does say:
instead of
as it should be outputting, when using prebuilt binary? |
I see
|
I'm still seeing this issue as well. Heroku locks the bundler version at 2.3.25, so upgrading to the latest isn't an option. I also see the error running the build on CircleCI:
|
@JunichiIto Exactly - So the prebuilt binaries are not release for 3.2.0; You're just running with compilation (the We should reopen this issue, as it is not solved. |
I have reopened a new issue, following the bug report template. |
I was experiencing the same problem with Heroku as well. What fixed it for me was running the following command to add the
I already had the
|
Ruby 3.2.0 has been released, but I couldn't deploy to Heroku with following error:
I'd appreciate if you could add Ruby 3.2 support soon.
Related links (discussions about Ruby 3.1)
The text was updated successfully, but these errors were encountered: