Fix Android platforms constraint #16246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using bazel platforms and new rules_android_ndk, crosstool_top is actually still `//external:android/crosstool`. The right way to detect Android is to use `constraint_value`.
acozzette
added
the
🅰️ safe for tests
acozzette
approved these changes
Mar 20, 2024
github-actions
bot
removed
the
🅰️ safe for tests
acozzette
approved these changes
Mar 21, 2024
acozzette
pushed a commit
to acozzette/protobuf
that referenced
this pull request
Mar 22, 2024
When using bazel platforms and new rules_android_ndk, crosstool_top is actually still `//external:android/crosstool`. The right way to detect Android is to use `constraint_value`. Closes protocolbuffers#16246 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#16246 from sifmelcara:fix-platforms dbf3fd5 PiperOrigin-RevId: 618198820
acozzette
added a commit
that referenced
this pull request
Mar 22, 2024
When using bazel platforms and new rules_android_ndk, crosstool_top is actually still `//external:android/crosstool`. The right way to detect Android is to use `constraint_value`. Closes #16246 COPYBARA_INTEGRATE_REVIEW=#16246 from sifmelcara:fix-platforms dbf3fd5 PiperOrigin-RevId: 618198820 Co-authored-by: Ming-Chuan <10496191+sifmelcara@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using bazel platforms and new rules_android_ndk, crosstool_top is actually still
//external:android/crosstool. The right way to detect Android is to useconstraint_value.