Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Ruby to use upb_msg in its C extension #6241

Closed
haberman opened this issue Jun 11, 2019 · 2 comments
Closed

Migrate Ruby to use upb_msg in its C extension #6241

haberman opened this issue Jun 11, 2019 · 2 comments
Assignees
@haberman
Labels
ruby

Comments

@haberman
Copy link
Member

upb_msg is a new data structure in upb that provides a language-agnostic message representation.

Once it is ready in upb, we should migrate the Ruby implementation to use it. This will greatly simplify the code, and should also improve performance. Some profiles show GC using 80% of CPU when parsing large messages. In the upb_msg model, Ruby wrapper objects are only created when accessed.
@haberman haberman added the ruby label Jun 11, 2019
@haberman haberman self-assigned this Jun 11, 2019
@sprql
Copy link

sprql commented Jan 28, 2021

Related: #8184

@haberman
Copy link
Member Author

Yes, this is fixed in #8184.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haberman haberman

Labels
ruby
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haberman @sprql