Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a UBSAN warnings. #6333

Merged
merged 1 commit into from Jul 3, 2019
Merged

fix a UBSAN warnings. #6333

merged 1 commit into from Jul 3, 2019

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Jul 2, 2019

Fixing a UBSAN error reproduced from an OSS-Fuzz testcase

  • external/com_google_protobuf/src/google/protobuf/stubs/strutil.cc:1071:9: runtime error: negation of -2147483648 cannot be represented in type 'google::protobuf::int32' (aka 'int'); cast to an unsigned type to negate this value to itself

Similar to #5901 for 32-bit integers.

Signed-off-by: Asra Ali asraa@google.com

Signed-off-by: Asra Ali <asraa@google.com>
@acozzette acozzette added the c++ label Jul 3, 2019
@acozzette acozzette merged commit de3e728 into protocolbuffers:master Jul 3, 2019
@acozzette
Copy link
Member

Thanks, @asraa.

htuch pushed a commit to envoyproxy/envoy that referenced this pull request Jul 10, 2019
In addition to updating protobuf to 3.8.0, this PR also

Removes old protobuf patch now included in 3.8.0
- Patches protocolbuffers/protobuf#6333 that fixes a UBSAN error in the protobuf library.
- Patches protobuf's BUILD to depend on foreign_cc zlib

Risk level: low/medium
Testing: bazel test //test/...

Signed-off-by: Asra Ali <asraa@google.com>
mattklein123 pushed a commit to envoyproxy/data-plane-api that referenced this pull request Jul 10, 2019
In addition to updating protobuf to 3.8.0, this PR also

Removes old protobuf patch now included in 3.8.0
- Patches protocolbuffers/protobuf#6333 that fixes a UBSAN error in the protobuf library.
- Patches protobuf's BUILD to depend on foreign_cc zlib

Risk level: low/medium
Testing: bazel test //test/...

Signed-off-by: Asra Ali <asraa@google.com>

Mirrored from https://github.com/envoyproxy/envoy @ 8246167b9d238797cbc6c03dccc9e3921c37617d
lizan pushed a commit to envoyproxy/envoy that referenced this pull request Sep 27, 2019
Adds back protobuf patch fixing UBSAN error (protocolbuffers/protobuf#6333).
This was removed on updating protobuf to 3.9.1, but will be included in the protobuf 3.10 release.

Fixes OSS-Fuzz issue:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=17759
Testing: Added corpus

Signed-off-by: Asra Ali <asraa@google.com>
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Oct 4, 2019
Adds back protobuf patch fixing UBSAN error (protocolbuffers/protobuf#6333).
This was removed on updating protobuf to 3.9.1, but will be included in the protobuf 3.10 release.

Fixes OSS-Fuzz issue:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=17759
Testing: Added corpus

Signed-off-by: Asra Ali <asraa@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants