Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObjC] Don't use unions and instead use memcpy for the type swaps. #6672

Merged
merged 1 commit into from Sep 20, 2019

Conversation

thomasvl
Copy link
Contributor

The code in question hasn't change in a long time so there likely is a compiler
change that is causing this to suddenly be an issue. memcpy should be a better
code pattern in general.

Should address firebase/firebase-ios-sdk#3851

@thomasvl thomasvl changed the title Doen't use unions and instead use memcpy for the type swaps. Don't use unions and instead use memcpy for the type swaps. Sep 19, 2019
@thomasvl thomasvl changed the title Don't use unions and instead use memcpy for the type swaps. [ObjC] Don't use unions and instead use memcpy for the type swaps. Sep 19, 2019
@paulb777
Copy link
Contributor

This still crashes
Screen Shot 2019-09-19 at 9 29 20 AM

@thomasvl
Copy link
Contributor Author

@paulb777 which Xcode version(s) and can you share your repo I can poke at it more directly?

The code in question hasn't change in a long time so the cause of
firebase/firebase-ios-sdk#3851 still appears to be
an Xcode 11 clang change/bug; but this does appear to be slightly better
code for the work being done.
@thomasvl thomasvl merged commit 5846439 into protocolbuffers:master Sep 20, 2019
@thomasvl thomasvl deleted the aligns branch September 20, 2019 14:52
thomasvl added a commit to thomasvl/protobuf that referenced this pull request Sep 20, 2019
…rotocolbuffers#6672)

The code in question hasn't change in a long time so the cause of
firebase/firebase-ios-sdk#3851 still appears to be
an Xcode 11 clang change/bug; but this does appear to be slightly better
code for the work being done.

Cleanup along the way for protocolbuffers#6679
thomasvl added a commit to thomasvl/protobuf that referenced this pull request Sep 20, 2019
…rotocolbuffers#6672)

The code in question hasn't change in a long time so the cause of
firebase/firebase-ios-sdk#3851 still appears to be
an Xcode 11 clang change/bug; but this does appear to be slightly better
code for the work being done.

Cleanup along the way for protocolbuffers#6679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants