Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix js message pivot selection #6813

Merged
merged 4 commits into from Feb 27, 2020
Merged

Fix js message pivot selection #6813

merged 4 commits into from Feb 27, 2020

Conversation

artiz
Copy link
Contributor

@artiz artiz commented Oct 28, 2019

I have found that protoc compiler incorrectly set field values in proto3 generated message wrappers in JavaScript. Incorrect implementation of jspb.Message.setFieldIgnoringDefault_ could lead to data array corruption or incorrect property value load if field number > 500.

I have prepared simple test case at https://github.com/artiz/google-protobuf-invalid-message-pivot-selection to verify incorrect behavior

@artiz artiz changed the title Fix js message pivot selection Fix js message pivot selection language:javascript Oct 28, 2019
@artiz artiz changed the title Fix js message pivot selection language:javascript Fix js message pivot selection label:javascript Oct 28, 2019
@artiz artiz changed the title Fix js message pivot selection label:javascript Fix js message pivot selection Oct 28, 2019
@rafi-kamal
Copy link
Contributor

@dankurka

@artiz
Copy link
Contributor Author

artiz commented Nov 11, 2019

Hi @TeBoring
Could you review this PR and plan when it could be merged into master?

@TeBoring TeBoring requested review from dankurka and removed request for TeBoring November 11, 2019 17:24
@artiz
Copy link
Contributor Author

artiz commented Dec 10, 2019

Ping

@artiz
Copy link
Contributor Author

artiz commented Feb 27, 2020

Bump!

@dankurka
Copy link
Contributor

This looks good to me

@dankurka dankurka merged commit 743a432 into protocolbuffers:master Feb 27, 2020
sthagen added a commit to sthagen/protocolbuffers-protobuf that referenced this pull request Feb 27, 2020
@@ -1217,6 +1217,7 @@ js_EXTRA_DIST= \
js/test_bootstrap.js \
js/testbinary.proto \
js/testempty.proto \
js/testlargenumbers.proto
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is missing a \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants