Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 3 parameter Encoding.GetString for default string values #6828

Merged
merged 1 commit into from Nov 5, 2019
Merged

Use 3 parameter Encoding.GetString for default string values #6828

merged 1 commit into from Nov 5, 2019

Conversation

ObsidianMinor
Copy link
Contributor

Encoding.GetString(byte[]) is actually incompatible with .NET Standard 1.0.

@ObsidianMinor ObsidianMinor mentioned this pull request Nov 4, 2019
Merged
@jtattermusch jtattermusch self-assigned this Nov 4, 2019
@jtattermusch jtattermusch self-requested a review November 4, 2019 15:30
@jtattermusch jtattermusch added the c# label Nov 4, 2019
@ObsidianMinor
Copy link
Contributor Author

The new .cs files from #6824 (OldExtensions2.cs and OldExtensions1.cs) didn't get added to Makefile.am.

@ObsidianMinor
Copy link
Contributor Author

Rebased on master, try rerunning tests @jtattermusch

@jtattermusch
Copy link
Contributor

FTR
https://docs.microsoft.com/en-us/dotnet/api/system.text.encoding.getstring?view=netstandard-1.0#System_Text_Encoding_GetString_System_Byte___System_Int32_System_Int32_

and

https://docs.microsoft.com/en-us/dotnet/api/system.text.encoding.getstring?view=netstandard-2.0#System_Text_Encoding_GetString_System_Byte___System_Int32_System_Int32_

jtattermusch
jtattermusch approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jtattermusch jtattermusch merged commit d052a05 into protocolbuffers:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtattermusch jtattermusch jtattermusch approved these changes

Assignees

@jtattermusch jtattermusch

Labels
c# cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ObsidianMinor @jtattermusch @googlebot @protobuf-kokoro