Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change _Extensions property to normal body rather than expression #6856

Merged
merged 1 commit into from Nov 8, 2019
Merged

Change _Extensions property to normal body rather than expression #6856

merged 1 commit into from Nov 8, 2019

Conversation

ObsidianMinor
Copy link
Contributor

Fixes issues with moving test codegen in #6832

cc: @jtattermusch

@jtattermusch jtattermusch self-assigned this Nov 8, 2019
jtattermusch
jtattermusch approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see what the tests say.

Were you able to verify that this is sufficient to make the generated files C# 3 compatible?

@jtattermusch jtattermusch merged commit db586e4 into protocolbuffers:master Nov 8, 2019
@jtattermusch jtattermusch mentioned this pull request Nov 8, 2019
Merged
@ObsidianMinor
Copy link
Contributor Author

Yes, I cherry-picked the changes locally to the other branch to make sure it compiles properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtattermusch jtattermusch jtattermusch approved these changes

Assignees

@jtattermusch jtattermusch

Labels
c# cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ObsidianMinor @jtattermusch @googlebot @protobuf-kokoro