Correctly set ExtensionRegistry when parsing with MessageParser, but using an already existing CodedInputStream #7246
Conversation
| byte[] bytes = message.ToByteArray(); | ||
| using (CodedInputStream input = new CodedInputStream(bytes)) | ||
| { | ||
| var parsed = TestAllExtensions.Parser.WithExtensionRegistry(new ExtensionRegistry() { UnittestExtensions.OptionalBoolExtension }).ParseFrom(input); |
There was a problem hiding this comment.
Thank you!
If at all possible, can there also be a way to pass an extension registry to ParseFrom/MergeFrom? It would be useful to be able to use the static MessageParser that's already present for a message and not have to construct a new one, or to be able to construct a new message and use MergeFrom with some stream and an extension registry. The current behavior of having WithExtensionRegistry create a new MessageParser each time is not ideal when parsing many different types of messages very quickly e.g. in an RPC system.
|
It this PR still needed to fix a problem? |
|
I think so, assuming by the fact that there's still no conflicts. It should've been swapping out the extension registry the whole time like it does with DiscardUnknownFields. |
jtattermusch
changed the title
Fixes #7241