Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application note for explicit presence tracking. #7390

Merged
merged 3 commits into from Apr 23, 2020

Conversation

dlj-NaN
Copy link
Contributor

@dlj-NaN dlj-NaN commented Apr 16, 2020

Singular, non-message typed fields in proto3 experimentally support explicit presence tracking (see docs/field_presence.md for details).

This includes instructions for enabling explicit presence tracking in proto3, and also explains implicit presence. The language examples were written by inspection, and not individually tested.
Copy link
Member

@haberman haberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to get through all of this yet, but a few preliminary comments.

docs/field_presence.md Outdated Show resolved Hide resolved
docs/field_presence.md Outdated Show resolved Hide resolved
Copy link
Member

@haberman haberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I went through the rest of the doc and found a few more things.

docs/field_presence.md Outdated Show resolved Hide resolved
docs/field_presence.md Show resolved Hide resolved
docs/field_presence.md Outdated Show resolved Hide resolved
docs/field_presence.md Outdated Show resolved Hide resolved
docs/field_presence.md Outdated Show resolved Hide resolved
docs/field_presence.md Outdated Show resolved Hide resolved
docs/field_presence.md Show resolved Hide resolved
docs/field_presence.md Outdated Show resolved Hide resolved
 - noted experimental status in release 3.12
 - clarified JSON null and ordering concerns
 - "implicit presence" -> "no presence"
 - clarified message presence in proto3
 - fixed round-trip example (client definitions were switched)
@dlj-NaN dlj-NaN merged commit e48c929 into protocolbuffers:master Apr 23, 2020
@dlj-NaN dlj-NaN deleted the appnote branch April 23, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants