Howto doc for implementing proto3 presence in a code generator. #7407
+274
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! I see this has a reference to files in #7390 . I'll hold off merging until that's in (but feel free to merge sooner if you don't mind the broken link). |
dlj-NaN
approved these changes
Apr 23, 2020
thomasvl
reviewed
Apr 23, 2020
| not aware of proto3 presence. The synthetic oneof should not appear anywhere | ||
| in the generated API. | ||
|
|
||
| ### Satisfying the Experimental Check |
There was a problem hiding this comment.
Josh - do you want to comment on how long this will be needed? i.e. - timeline for the removal of the flag (but that the feature check within protoc will remain after that)?
|
@thomasvl I will send you a separate PR to address this, and add a few more notes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.