Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubygems release 3.12.0 differs from github release version #7518

Closed
mikelorant opened this issue May 16, 2020 · 3 comments
Closed

Rubygems release 3.12.0 differs from github release version #7518

mikelorant opened this issue May 16, 2020 · 3 comments

Comments

@mikelorant
Copy link

Checking the code for the tag of the Ruby release 3.12.0 shows the following:

s.required_ruby_version = '>= 2.3'

https://github.com/protocolbuffers/protobuf/blob/v3.12.0/ruby/google-protobuf.gemspec

However download the Gem from Rubygems shows:

s.required_ruby_version = Gem::Requirement.new([">= 2.5".freeze, "< 2.8.dev".freeze])

This is causing issues with applications dependent on this such as aws-fluent-plugin-kinesis.

ERROR:  Error installing fluent-plugin-kinesis:
	google-protobuf requires Ruby version < 2.8.dev, >= 2.5.
@haberman
Copy link
Member

It appears that RubyGems rewrites our gemspec when the gem is uploaded.

However the rewritten gemspec is arguably more correct, as we dropped support for binary gems for Ruby <2.5: #7453. It had become impossible to build our gem on these versions. Also upstream dropped support for Ruby 2.3 on 2019-03-31 and Ruby 2.4 on 2020-03-31.

This is mentioned in the changelog for Ruby:

https://github.com/protocolbuffers/protobuf/releases/tag/v3.12.0

Sorry to hear this is causing problems for you. If you are still on an older version of Ruby is it possible to keep using the older version of protobuf?

@mikelorant
Copy link
Author

Thanks for the explanation. Closing the issue.

@haberman
Copy link
Member

Ruby 2.3 and 2.4 are supported again in 3.12.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants