Restore binary builds for Ruby 2.3 and 2.4 #7529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I apparently do not have permissions to edit a PR after creating. I'm going to close and re-open. |
|
Okay never mind. I can't edit labels when opening a PR either. Someone else will have to add the "ruby" and "release notes: yes" labels. |
|
@haberman What needs to be done to get this merged and released? I can update the version to 3.12.0.1 if you want, but I don't think I have access to any of the release tooling. |
|
@dazuma Can you submit this to the 3.12.x branch also? That is what we will be cutting the patch release from. |
|
@haberman will do. |
dazuma
added a commit
to dazuma/protobuf
that referenced
this pull request
May 19, 2020
haberman
pushed a commit
that referenced
this pull request
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundle updatewhen building, to ensure that dependencies are re-resolved after rvm switches to a new Ruby, just in case the requirements are different.@haberman is summoned.