Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotate ByteString.CopyFrom(ReadOnlySpan<byte>) as SecuritySafeCritical #7701

Merged

Conversation

basvdlinden
Copy link
Contributor

@basvdlinden basvdlinden commented Jul 12, 2020

The change to test solution for issue:

Can't call ByteString.CopyFrom(ReadOnlySpan bytes) on net45 #7700

Fixes #7700

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@basvdlinden
Copy link
Contributor Author

basvdlinden commented Jul 12, 2020 via email

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@jtattermusch jtattermusch self-assigned this Oct 27, 2020
@jtattermusch jtattermusch merged commit 9d9c670 into protocolbuffers:master Oct 27, 2020
@basvdlinden basvdlinden deleted the safe_bytestring_copyfrom_span branch October 31, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't call ByteString.CopyFrom(ReadOnlySpan<byte> bytes) on net45
4 participants