Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding forgotten duration.proto to the lite library #7738

Merged
merged 3 commits into from Jul 20, 2020

Conversation

robcos
Copy link

@robcos robcos commented Jul 20, 2020

timestamp.proto is part of the java lite release but duration is not.
I assume this is accidental.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@robcos
Copy link
Author

robcos commented Jul 20, 2020

@googlebot I signed it!

@robcos
Copy link
Author

robcos commented Jul 20, 2020

release notes: yes

@acozzette
Copy link
Member

Thanks, @robcos.

@acozzette acozzette merged commit 8c91d71 into protocolbuffers:master Jul 20, 2020
@robcos
Copy link
Author

robcos commented Jul 20, 2020

This commit fixes #7094

@robcos
Copy link
Author

robcos commented Jul 21, 2020

@acozzette (I think I met you but don't know where :-)) Do you have an idea of when this is going to be released?

@acozzette
Copy link
Member

I think we might have met at the YouTube office in San Bruno one time. I'm working on a release now so let me just cherry-pick this since it is a small fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants