Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 3.12.0 crash on iPhone5 #7742

Closed
aiqinxuancai opened this issue Jul 21, 2020 · 3 comments
Closed

version 3.12.0 crash on iPhone5 #7742

aiqinxuancai opened this issue Jul 21, 2020 · 3 comments

Comments

@aiqinxuancai
Copy link

We use the OC version of Protobuf 3.12.0 which is install by pod.

According to the collected crash logs, the problem only occurs on 32-bit devices such as iPhone5, iPhone4s, iPad4, and iPadMini.

GPBCodedInputStreamReadDouble (GPBCodedInputStream.m:134 [Inline: GPBConvertInt64ToDouble])
1	Wolf
GPBCodedInputStreamReadDouble (GPBCodedInputStream.m:103)
2	Wolf
-[GPBMessage mergeFromCodedInputStream:extensionRegistry:] (GPBMessage.m:2143)
3	Wolf
-[GPBMessage mergeFromData:extensionRegistry:] (GPBMessage.m:1928)
4	Wolf
-[GPBMessage initWithData:extensionRegistry:error:] (GPBMessage.m:0)
5	Wolf
+[GPBMessage parseFromData:extensionRegistry:error:] (GPBMessage.m:1957)
6	Wolf
+[GPBMessage parseFromData:error:] (GPBMessage.m:1951)
7	Wolf
__45-[NetworkServiceManager receiveData:reqInfo:]_block_invoke (NetworkServiceManager.mm:0)
8	libdispatch.dylib
__dispatch_call_block_and_release + 11
9	libdispatch.dylib
__dispatch_queue_drain$VARIANT$mp + 1759
10	libdispatch.dylib
__dispatch_queue_invoke$VARIANT$mp + 285
11	libdispatch.dylib
__dispatch_root_queue_drain + 1561
12	libdispatch.dylib
__dispatch_worker_thread3 + 97
13	libsystem_pthread.dylib
_pthread_wqthread + 1024```
@thomasvl
Copy link
Contributor

This sounds like what was fixed in #6678 last year.

What version of Xcode? Are you sure you are getting 3.12.x protobuf? Can you make a simple repro project that shows the issue?

@thomasvl
Copy link
Contributor

From your call stack, GPBCodedInputStream.m:134 lines up with a valid line from before the mentioned fix. Looking at the sources in the 3.12 release, that line number does not match. So it does seem to indicate you aren't using the 3.12 release and using someting older that does have the bug.

@aiqinxuancai
Copy link
Author

Sorry, I made a mistake.

It has been confirmed that there is no crash when using version 3.12.0, which seems to be caused by Jenkins not being updated to the latest version in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants