Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyUnknownFields memory leak #7928

Merged
merged 1 commit into from Nov 6, 2020
Merged

Conversation

agrenott
Copy link
Contributor

Properly release internal data structure on deallocation.
Fix #7301

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@agrenott
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Properly release internal data structure on deallocation.
Fix protocolbuffers#7301
@agrenott
Copy link
Contributor Author

agrenott commented Oct 1, 2020

I disabled the new memory leak unit test for python versions <3.4 (as tracemalloc wasn't available back then).

@agrenott
Copy link
Contributor Author

agrenott commented Oct 5, 2020

Hi,
Is anything on my side missing to get this PR reviewed/integrated?
This leak's quite a show-stopper on our side.
Thx

@agrenott
Copy link
Contributor Author

agrenott commented Nov 6, 2020

Hi,
Any idea when this PR could get merged (or what's missing)?
Thx.

@dlj-NaN dlj-NaN merged commit 5f7f389 into protocolbuffers:master Nov 6, 2020
@dlj-NaN
Copy link
Contributor

dlj-NaN commented Nov 6, 2020

Thanks, and sorry for the delay.

@agrenott
Copy link
Contributor Author

Hi,
Thanks for the merge.
Is there a way to get it merged into the on-going 3.14.x branch? If so what's the process?

acozzette pushed a commit to acozzette/protobuf that referenced this pull request Nov 12, 2020
Properly release internal data structure on deallocation.
Fix protocolbuffers#7301
acozzette added a commit to acozzette/protobuf that referenced this pull request Nov 12, 2020
@acozzette
Copy link
Member

@agrenott Thanks for flagging this, I created #8032 to cherry-pick this fix into the 3.14.x branch.

acozzette pushed a commit that referenced this pull request Nov 12, 2020
Properly release internal data structure on deallocation.
Fix #7301
acozzette added a commit that referenced this pull request Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python] PyUnknownFields Memory leak
5 participants