Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP C Extension doesn't implement hasOneof() #8001

Closed
haberman opened this issue Nov 2, 2020 · 2 comments
Closed

PHP C Extension doesn't implement hasOneof() #8001

haberman opened this issue Nov 2, 2020 · 2 comments
Assignees
@haberman
Labels
php

Comments

@haberman
Copy link
Member

haberman commented Nov 2, 2020

The generated code contains calls to $this->hasOneof(), but that function is not implemented in the C extension.

This causes errors if a user calls the hasFoo() method for any oneof field with the C extension.
@haberman haberman added the php label Nov 2, 2020
@haberman haberman self-assigned this Nov 2, 2020
@PierrickVoulet
Copy link

This seems to be a duplicate of #7961

@anight anight mentioned this issue Nov 3, 2020
Merged
@haberman
Copy link
Member Author

This was fixed in #8003.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haberman haberman

Labels
php
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haberman @PierrickVoulet