Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.14.0RC1] strange changes #8019

Closed
remicollet opened this issue Nov 9, 2020 · 3 comments
Closed

[3.14.0RC1] strange changes #8019

remicollet opened this issue Nov 9, 2020 · 3 comments

Comments

@remicollet
Copy link

Is it tag from the right branch / sources ?

Looks like major changes introduced in 3.13 were reverted:

Compatibility with PHP 8.0 is broken again.

@haberman
Copy link
Member

haberman commented Nov 9, 2020

The major changes in 3.13 were not reverted. What you are seeing is the result of #7944, which does effectively revert one small part of the 3.13 changes. The well-known types are now implemented in native C again, in an effort to avoid the overhead of autoloading PHP for them. But all of the major architectural changes to the C extension and the corresponding performance gains should still be present in 3.14.0RC1.

Thanks for the note about PHP 8.0 compatibility. We haven't been able to get PHP8.0 testing into our pipeline yet.

@stevesweets
Copy link

stevesweets commented Jan 11, 2021

Is there any idea when php8 support may arrive?

@haberman
Copy link
Member

PHP8 support is fixed in master (#8105) and will be a part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants